Skip to content

Add --quiet option to isort command #31733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2020

Conversation

d1618033
Copy link
Contributor

@d1618033 d1618033 commented Feb 6, 2020

@alimcmaster1 alimcmaster1 added the CI Continuous Integration label Feb 6, 2020
@alimcmaster1
Copy link
Member

What does the output look like whenever an import is incorrectly sorted? Let’s push a commit here (you can mess up import ordering in any file) so we can double check all looks as expected on github actions

@d1618033
Copy link
Contributor Author

d1618033 commented Feb 6, 2020

@alimcmaster1 done. the output looks like this in case of an error:

Check import format using isort
##[error]ERROR: /home/runner/work/pandas/pandas/pandas/_config/config.py Imports are incorrectly sorted.
Check import format using isort DONE

@alimcmaster1
Copy link
Member

LGTM - thanks. cc @datapythonista

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if errors are still displayed? If that's the case, this lgtm.

Thanks!

@d1618033 d1618033 requested a review from alimcmaster1 February 7, 2020 05:51
@d1618033
Copy link
Contributor Author

d1618033 commented Feb 7, 2020

@datapythonista The errors are still displayed.
This is a snippet from the output of this commit where I changed the order of the imports to verify that errors are still being displayed (the CI logs seem to have been deleted, unfortunately)

@datapythonista datapythonista merged commit cf01369 into pandas-dev:master Feb 7, 2020
@datapythonista
Copy link
Member

Thanks for researching and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix isort output in CI
3 participants